From: Stefan Sperling Subject: Re: initial gotd-secrets.conf implementation To: Omar Polo Cc: gameoftrees@openbsd.org Date: Mon, 9 Sep 2024 11:38:04 +0200 On Mon, Sep 09, 2024 at 11:12:48AM +0200, Omar Polo wrote: > Here's the diff. It supports quoting with both single and double > quotes, as well as escaping. plus, there's also a new regress. > > One more thing that I'd like to do after this maybe is rename the "auth" > keyword to "http". > > ok? Thanks, ok by me. Abiding by the principle of "never write your own lexer" I wonder if we shouldn't be trying to use a parse.y-based parser for this instead of a custom oner. But what you have works, and has tests, and the input is created by the sysadmin. So I'm not too worried. There are some typos and the new test output could be tweaked to match existing tests. But those aren't blocking problems.