From: Stefan Sperling <stsp@stsp.name>
Subject: Re: implement gotwebd test harness
To: Mark Jamsek <mark@jamsek.com>
Cc: gameoftrees@openbsd.org
Date: Sun, 24 Nov 2024 14:10:34 +0100

On Sun, Nov 24, 2024 at 04:52:18PM +1100, Mark Jamsek wrote:
> The below diff implements a test harness for gotwebd. I've tried to keep
> the test case interface consistent with the rest of our regress suite
> and think I've succeeded for the most part. stsp convinced me on IRC to
> keep the expected content in stable files and keep the markup, both of
> which I think are good ideas.
> 
> I haven't written any documentation yet as I wanted to share it first,
> but, like gotd, it needs to be invoked with privileges though it drops
> to the GOTWEBD_TEST_USER (by default the doas user) where possible.
> 
> To test it out, make sure you have a gotwebd binary on your path,
> and run `doas make webd-regress` from the root of your got work tree.
> 
> Please review the shell bits in particular, much of the setup was lifted
> from gotd regress so should be good. And thanks to a misc@ post, I also
> realised last night that I could lift a bunch of code from base, which
> I'm much happier with than the initial implementation I wrote from the
> fastcgi spec!

Ok by me, thanks so much!  Please put it in. We can keep tweaking it.