From: Mark Jamsek <mark@jamsek.com>
Subject: Re: got-read-gotconfig zombies
To: Stefan Sperling <stsp@stsp.name>
Cc: gameoftrees@openbsd.org
Date: Mon, 02 Dec 2024 16:54:15 +1100

Stefan Sperling <stsp@stsp.name> wrote:
> One of my gotwebd servers stopped responding to requests and had
> failing cronjobs because the system's process table was full.
> 
> Upon closer inspection I found several thousand got-read-gotconfig
> zombie child processes of gotwebd.
> 
> I am not sure why those were never cleaned up, however the code
> doesn't wait for children if an errror occurs after forking so
> maybe it ran out of files or memory first and then accumulated
> all those zombies?
> 
> Has anyone else seen something like this happen?
> 
> Attempt to fix this for both gitconfig and gotconfig below, I am
> running this on my server now.
> 
> ok?

I can't recall seeing this problem but your change makes sense and
reads good so ok for me (and sorry for the late review!)


-- 
Mark Jamsek <https://bsdbox.org>
GPG: F2FF 13DE 6A06 C471 CA80  E6E2 2930 DC66 86EE CF68