From: Omar Polo <op@omarpolo.com>
Subject: Re: gotwebd request logging
To: Mark Jamsek <mark@jamsek.com>, Stefan Sperling <stsp@stsp.name>
Cc: gameoftrees@openbsd.org
Date: Fri, 6 Dec 2024 15:03:34 +0100

On 06/12/24 09:27, Mark Jamsek wrote:
> Stefan Sperling <stsp@stsp.name> wrote:
>> On Fri, Dec 06, 2024 at 04:11:05PM +1100, Mark Jamsek wrote:
>>> Stefan Sperling <stsp@stsp.name> wrote:
>>>> Make gotwebd log requests at -v verbosity.
>>>>
>>>> ok?
>>> ok for the change but three lines exceed 80 columns; suggested reflow
>>> annotated inline (although wrapping at the comparison operator always
>>> looks awkward to me so whichever way you like is ok for me :)
>> Ah, indeed, thanks. I've rewrapped all those lines like this
>> before comitting it:
> Even better! Thanks :)
>
>> 		if (c->server_name[0] &&
>> 		    stravis(&server_name, c->server_name, VIS_SAFE) == -1) {


+1 for me too


Thanks,

Omar Polo