From: Stefan Sperling <stsp@stsp.name>
Subject: Re: gotwebd login hint ssh fingerprints
To: Omar Polo <op@omarpolo.com>
Cc: gameoftrees@openbsd.org
Date: Tue, 10 Feb 2026 12:08:55 +0100

On Tue, Feb 10, 2026 at 12:02:32PM +0100, Omar Polo wrote:
> > [...]
> >  <div id="err_content">
> >    {{ if t->error }}
> > -    {{ t->error->msg }}
> > +    {{ if t->error->code == GOT_ERR_LOGIN_HINT && login_hint_user }}
> > +      Log in by running: 
> > +      {{ if login_hint_port }}
> > +	ssh -p {{ login_hint_port }} {{" "}} {{ login_hint_user }}@{{ srv->name }} {{" "}} "weblogin {{ srv->name }}"
> 
> just one nit, while we are here, can't we wrap this into <pre>?

I wouldn't mind. I even did consider adding <pre>. But since it might change
the expected output for tests and I had the tests passing already I decided
to go without <pre> for now, as it has always been. We could add <pre> later.
 
> > +	
> > +      {{ else }}
> > +	ssh {{ login_hint_user }}@{{ srv->name }} {{" "}} "weblogin {{ srv->name }}"
> 
> and this too
> 
> > +      {{ end }}
> > +      {{ if srv->sshfp[GOTWEBD_SSHFP_ECDSA][0] != '\0' ||
> > +          srv->sshfp[GOTWEBD_SSHFP_ED25519][0] != '\0' ||
> > +          srv->sshfp[GOTWEBD_SSHFP_RSA][0] != '\0' }}
> 
> ok anyway op@

THanks :)