From: Stefan Sperling <stsp@stsp.name>
Subject: Re: got fails to build on alpha
To: Martijn van Duren <openbsd+got@list.imperialat.at>
Cc: Theo Buehler <tb@theobuehler.org>, "gameoftrees@openbsd.org" <gameoftrees@openbsd.org>
Date: Sat, 10 Oct 2026 15:22:47 +0200

On Sat, Oct 10, 2026 at 03:10:41PM +0200, Martijn van Duren wrote:
> These fix got-fetch-pack, and gotsh builds for me.
> There's a couple of -Werror things I'll get back at separately.

Thanks, glad it helps. I will commit it then.

> Haven't looked too closely at the diff, but wouldn't it make sense to
> use asprintf instead of calloc+snprintf, and strdup instead of calloc+
> strlcpy?
 
The Git protocol imposes a maximum size on a pkt-line so I think it
makes sense to use an appropriately sized buffer in this specific case.