On 10/10/19(Thu) 16:45, Stefan Sperling wrote:
> On Thu, Oct 10, 2019 at 03:54:12PM +0200, Stefan Sperling wrote:
> > On Thu, Oct 10, 2019 at 01:46:49PM +0200, Martin Pieuchot wrote:
> > > Diff below makes tog(1) freeze as soon as it tries to go beyond the
> > > first page.  Nothing seems to be fetched before that.  The top bar keeps
> > > displaying:
> > > 
> > > commit ........................................ /sys [46/49] searching...
> > > 
> > > Pressing 'n' doesn't refresh the view.
> > 
> > That is very strange, it is work just fine here.
> 
> Can you please try this diff just to check if this helps?
> If it does, we need to find a proper way of fixing this.

With this diff I can still reproduce a freeze if I search for a pattern
that is never matched.  tog(1) keeps 'searching' without displaying
anything and without answering to any key pressed.
 
> diff 366e0a5f18070d353035fdfa945719809c60f0aa /home/stsp/src/got
> blob - aad8017a1963e96977883c2dadfcef0fce8eac58
> file + tog/tog.c
> --- tog/tog.c
> +++ tog/tog.c
> @@ -1793,10 +1793,12 @@ search_next_log_view(struct tog_view *view)
>  	}
>  
>  	if (s->search_entry) {
> +#if 0
>  		if (wgetch(view->window) == KEY_BACKSPACE) {
>  			view->search_next_done = 1;
>  			return NULL;
>  		}
> +#endif
>  		if (view->searching == TOG_SEARCH_FORWARD)
>  			entry = TAILQ_NEXT(s->search_entry, entry);
>  		else