"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: got clone: start of effort.
To:
Ori Bernstein <ori@eigenstate.org>, gameoftrees@openbsd.org
Date:
Sun, 12 Jan 2020 19:21:35 +0100

Download raw body.

Thread
On Thu, Dec 19, 2019 at 10:49:28AM +0100, Stefan Sperling wrote:
> On Wed, Dec 18, 2019 at 08:27:21PM -0800, Ori Bernstein wrote:
> > Sorry, slow responses -- I was in the middle of packing up, now
> > in the middle of packing up and moving. It seems like I forgot
> > to ammend the commit before exporting the patch...
> > 
> > Hopefully this is better.
> 
> It is, thank you very much!
> 
> I will need to find some time to look at it in detail, which
> probably won't happen until next year ;-)

It seems you forgot to add some files. See diffstat below for a list of
what was included in the diff you sent.

The patch is missing some libexec helper code, in particular got-fetch-pack.c
which is referenced in lib/fetch.c; do you still have this file somewhere,
or does this not yet exist?

The file got-send-pack.c is also missing, but I suppose that's because
this diff only implements clone, not push, correct?

Thanks!

 got/Makefile                            |    2 
 got/got.c                               |   40 +
 include/got_error.h                     |    7 
 lib/fetch.c                             |  342 ++++++++
 lib/got_lib_object_idset.h              |    3 
 lib/got_lib_privsep.h                   |   31 
 lib/inflate.c                           |    6 
 lib/object.c                            |    1 
 lib/object_idset.c                      |    8 
 lib/privsep.c                           |  105 ++
 libexec/Makefile                        |    3 
 libexec/got-index-pack/got-index-pack.c | 1270 ++++++++++++++++++++++++++++++++
 12 files changed, 1816 insertions(+), 2 deletions(-)