"GOT", but the "O" is a cute, smiling sun Index | Thread

"Todd C. Miller" <Todd.Miller@sudo.ws>
Re: fix 'got log -p path' bug
Stefan Sperling <stsp@stsp.name>
Mon, 04 May 2020 07:37:04 -0600

Download raw body.

On Mon, 04 May 2020 15:06:22 +0200, Stefan Sperling wrote:

> I noticed that this command in got's own Git repository will error
> out on the commit which added .gitignore:
> 	got log -p .gitignore
> The unexpected error is "got: no such entry found in tree".
> This is a legitimate condition: The path does not exist in the parent
> commit of the commit which added the .gitignore file. What is going wrong
> is that our code doesn't gracefully handle this error condition.

OK millert@.  The existing code handles id_str1 and obj_id1 being
NULL so this is safe.

 - todd