"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: POSIX shell portability fixes under regress/
To:
Ryo ONODERA <ryo@tetera.org>
Cc:
gameoftrees@openbsd.org
Date:
Mon, 28 Dec 2020 18:40:48 +0100

Download raw body.

Thread
On Mon, Dec 28, 2020 at 11:04:44PM +0900, Ryo ONODERA wrote:
> Hi,
> 
> Thanks for your great software.
> 
> Some shell scripts under regress/ directory
> use [s1 == s2] syntax to compare strings.
> In POSIX way, this is defined as [s1 = s2].
> See:
> https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html
> 
> Could you apply the following patch for commit
> c80f5f010956d72c751b435eca30d106a3ac5a26 ?
> 
> I have read some emails that report bugs or new features in
> the mailing list archive, however I am not sure how to submit my patch.
> If I have mistakes, I will resend my patch in correct manner.
> 
> Thank you.

Hi Ryo,

I have committed your patch, thank you!
I did not know that == is not POSIX syntax.

Cheers,
Stefan