"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Ryo ONODERA <ryo@tetera.org>
Subject:
Re: POSIX shell portability fixes under regress/
To:
Stefan Sperling <stsp@stsp.name>
Cc:
gameoftrees@openbsd.org
Date:
Tue, 29 Dec 2020 14:08:22 +0900

Download raw body.

Thread
Hi,

Stefan Sperling <stsp@stsp.name> writes:

> On Mon, Dec 28, 2020 at 11:04:44PM +0900, Ryo ONODERA wrote:
>> Hi,
>> 
>> Thanks for your great software.
>> 
>> Some shell scripts under regress/ directory
>> use [s1 == s2] syntax to compare strings.
>> In POSIX way, this is defined as [s1 = s2].
>> See:
>> https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html
>> 
>> Could you apply the following patch for commit
>> c80f5f010956d72c751b435eca30d106a3ac5a26 ?
>> 
>> I have read some emails that report bugs or new features in
>> the mailing list archive, however I am not sure how to submit my patch.
>> If I have mistakes, I will resend my patch in correct manner.
>> 
>> Thank you.
>
> Hi Ryo,
>
> I have committed your patch, thank you!
> I did not know that == is not POSIX syntax.

Thank you very much.

And Christian Weisgerber have pointed out in another email
that my patch is not sufficient to full POSIX compliance.
I will find a time to improve some problems in shell scripts later.

> Cheers,
> Stefan

-- 
Ryo ONODERA // ryo@tetera.org
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3