"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: fix ibuf memory leak
To:
Tracey Emery <tracey@traceyemery.net>, gameoftrees@openbsd.org
Date:
Sat, 19 Jun 2021 12:13:50 +0200

Download raw body.

Thread
On Sat, Jun 19, 2021 at 11:35:46AM +0200, Stefan Sperling wrote:
> Note that got_repo_close() checks whether privsep_child->imsg_fd == -1,
> before it calls imsg_clear(ibuf). got_repo_close() code should probably
> check whether ibuf is NULL such that got_pack_stop_privsep_child() could
> set it to NULL here, after freeing it.

Sorry, I was confused when I wrote the above.
The repository's privsep children are of course managed separately from
the got-read-pack children.