"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: fix ibuf memory leak
To:
Tracey Emery <tracey@traceyemery.net>
Cc:
gameoftrees@openbsd.org
Date:
Sat, 19 Jun 2021 17:59:59 +0200

Download raw body.

Thread 
On Sat, Jun 19, 2021 at 09:25:22AM -0600, Tracey Emery wrote:
> Ok for below then? The static change is your call.

Yes, ok! Thanks for tracking this down :)

> diff 779e1159b25b2aa115e6b42f51003b7e2fa7c06b /home/tracey/src/got
> blob - 137217342b5f0eb662a63182136a6750ffa7e2af
> file + lib/pack.c
> --- lib/pack.c
> +++ lib/pack.c
> @@ -552,6 +552,8 @@ got_pack_stop_privsep_child(struct got_pack *pack)
>  	err = got_privsep_wait_for_child(pack->privsep_child->pid);
>  	if (close(pack->privsep_child->imsg_fd) == -1 && err == NULL)
>  		err = got_error_from_errno("close");
> +	imsg_clear(pack->privsep_child->ibuf);
> +	free(pack->privsep_child->ibuf);
>  	free(pack->privsep_child);
>  	pack->privsep_child = NULL;
>  	return err;
> 
>