"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: Provide lib/Makefile to enable tags file generation
To:
gameoftrees@openbsd.org
Date:
Thu, 7 Oct 2021 16:09:41 +0200

Download raw body.

Thread
On Thu, Oct 07, 2021 at 02:03:11PM +0000, Klemens Nanni wrote:
> The root Makefile does not hook into lib/ via <bsd.subdir.mk> since it
> is not a program itself and thus gets included by all others.
>  
> This means `make tags` skips lib/ and `make -C lib/ tags` does not know
> what to do;  provide a minimal <bsd.prog.mk> stub and hook it up just
> or the "tags" such that *all* source is browsable via tags.

It looks like bsd.dep.mk could be included instead of bsd.prog.mk?
It seems that's where the make rule for ctags is implemented.

I hope we won't forget to update the list of files in this Makefile.
But I guess the damage of such negligence would be limited ;-)
  
> diff 4afb33a50adb03566efa20a315bf6fb7ad0b74df 621b319ffbf42ff9214f46b94e4ef88cf315bff9
> blob - 5e96ac3cb604c6c6ffb943a5f7620395583905f4
> blob + bcee8dd56be2cbbc7d735892c67f6c50a1062163
> --- Makefile
> +++ Makefile
> @@ -10,6 +10,10 @@ SUBDIR += regress
>  SUBDIR += gotweb
>  .endif
>  
> +.if make(tags)
> +SUBDIR += lib
> +.endif
> +
>  .include "got-version.mk"
>  
>  release: clean
> blob - /dev/null
> blob + 362288c2b0a09394a3eaab1833389c8d76988ed4 (mode 644)
> --- /dev/null
> +++ lib/Makefile
> @@ -0,0 +1,11 @@
> +SRCS =	blame.c buf.c commit_graph.c deflate.c delta.c delta_cache.c deltify.c \
> +	dial.c diff.c diff3.c diff_atomize_text.c diff_main.c diff_myers.c \
> +	diff_output.c diff_output_edscript.c diff_output_plain.c \
> +	diff_output_unidiff.c diff_patience.c diffreg.c error.c fetch.c \
> +	fileindex.c gitconfig.c gitproto.c gotconfig.c inflate.c lockfile.c \
> +	object.c object_cache.c object_create.c object_idset.c object_parse.c \
> +	opentemp.c pack.c pack_create.c path.c pkt.c privsep.c rcsutil.c \
> +	reference.c repository.c repository_admin.c send.c sha1.c utf8.c \
> +	worktree.c
> +
> +.include <bsd.prog.mk>
> 
>