"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: Provide lib/Makefile to enable tags file generation
To:
gameoftrees@openbsd.org
Date:
Thu, 7 Oct 2021 16:22:35 +0200

Download raw body.

Thread
On Thu, Oct 07, 2021 at 02:18:01PM +0000, Klemens Nanni wrote:
> On Thu, Oct 07, 2021 at 04:09:41PM +0200, Stefan Sperling wrote:
> > On Thu, Oct 07, 2021 at 02:03:11PM +0000, Klemens Nanni wrote:
> > > The root Makefile does not hook into lib/ via <bsd.subdir.mk> since it
> > > is not a program itself and thus gets included by all others.
> > >  
> > > This means `make tags` skips lib/ and `make -C lib/ tags` does not know
> > > what to do;  provide a minimal <bsd.prog.mk> stub and hook it up just
> > > or the "tags" such that *all* source is browsable via tags.
> > 
> > It looks like bsd.dep.mk could be included instead of bsd.prog.mk?
> > It seems that's where the make rule for ctags is implemented.
> 
> Nope:
> 
> 	$ make -C lib tags
> 	make: don't know how to make _SUBDIRUSE (prerequisite of: tags)
> 	Stop in /home/kn/got/lib
> 
> But I can add a comment or even explicity set `PROG' to the empty string
> so it's clear this is a stub.

Fair enough. Yes, a comment which explains that all this is
intended for 'make tags' only would be good.

> > I hope we won't forget to update the list of files in this Makefile.
> > But I guess the damage of such negligence would be limited ;-)
> 
> Well, `SRCS = *.c' always works but I've never seen that in OpenBSD
> Makefiles which seem to always explicitly define sources.

Using *.c might be the best approach here because this would keep
'make tags' working as files get added or removed over time.