"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: object enumeration in got-read-pack
To:
Omar Polo <op@omarpolo.com>, gameoftrees@openbsd.org
Date:
Tue, 7 Jun 2022 21:34:07 +0200

Download raw body.

Thread
On Tue, Jun 07, 2022 at 12:34:15PM +0200, Stefan Sperling wrote:
> On Tue, May 24, 2022 at 10:06:28PM +0200, Stefan Sperling wrote:
> > This patch still has some design-level problems and I don't consider it
> > done yet. The current design works well for the case where we want to pack
> > every object that is referenced, but not so well when we want to pack only
> > a subset of objects; got-read-pack could end up doing a lot of unnecessary
> > work in that case. It only knows commits to start enumerating from, but has
> > no boundary commits that would tell it where to stop enumerating; it just
> > keeps going until it runs out of parent commits to traverse.
> > I still need to think about this some more.
> 
> Updated version, where we can send got-read-pack a list of boundary commits.
> Enumeration in the got-read-pack process will stop as soon as those commits
> have been reached.

This was committed but then backed out again in commit e44d9391
because the logic I implemented here has a flaw. See that commit
message for details if you are interested.