On 22-06-22 04:26pm, Stefan Sperling wrote:
> On Thu, Jun 23, 2022 at 12:18:03AM +1000, Mark Jamsek wrote:
> > On 22-06-22 02:51pm, Stefan Sperling wrote:
> > > On Wed, Jun 22, 2022 at 10:42:02PM +1000, Mark Jamsek wrote:
> > > > I'm happy to add an explicit abort key, or do you think documenting the
> > > > timeout and how that cancels a preceding count modifier would suffice?
> > > > If we add an abort key, what should we use if not backspace?
> > > 
> > > Yes, just documenting the timeout seems fine. I entirely missed that the
> > > number prompt will time out when I did my initial quick review.
> > > 
> > > The timeout should probably be configurable via env vars, but we can
> > > add this later.
> > 
> > ok, sounds good!
> > 
> > The updated diff adds the timeout to the man page and a couple minor fixes:
> > left-behind typo and ensuring that we scroll all the way up with C-u in
> > blame view if the count modifier is large enough
> 
> I am happy with this going patch in. But we should keep refining this for
> improved usability. I think some visual clue that the number is being
> parsed would be nice to have, as suggested in another message of this
> discussion thread.
> 
> I just noticed another minor issue, which is when you type something
> like 12345j in the log view, this has the same problem as typing G,
> locking tog into a seemingly endless loop of loading more commits.
> We might want to add a way to abort "loading..." of commits in the log
> view somehow, because in deep repositories this can be very annoying
> if triggered by accident.

Let me see if I can come up with something to fix that. It shouldn't
take long.

-- 
Mark Jamsek <fnc.bsdbox.org>
GPG: F2FF 13DE 6A06 C471 CA80  E6E2 2930 DC66 86EE CF68