"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Mark Jamsek <mark@jamsek.com>
Subject:
Re: J and K keybindings for diff view
To:
Mikhail <mp39590@gmail.com>, gameoftrees@openbsd.org
Date:
Tue, 19 Jul 2022 19:59:30 +1000

Download raw body.

Thread
On 22-07-19 11:57am, Stefan Sperling wrote:
> On Tue, Jul 19, 2022 at 07:53:22PM +1000, Mark Jamsek wrote:
> > On 22-07-17 09:23pm, Mikhail wrote:
> > > This patch adds J and K bindings for diff view to move to the next and
> > > previous commits respectively. It mimics keybindings which are found in
> > > mutt while you're in mail view. I've found it very convenient, because
> > > you can scroll diff with j/k and when you're done, don't move hands to
> > > another part of a keyboard to see next/previous commit.
> > 
> > I like this. I use it in mutt too and it will be nice to have that
> > consistency between apps in frequent use.
> 
> No objections here. Should these new key bindings be supported
> in the blame view, too, for consistency?

Yes, I think that's a good idea.

-- 
Mark Jamsek <fnc.bsdbox.org>
GPG: F2FF 13DE 6A06 C471 CA80  E6E2 2930 DC66 86EE CF68