"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Mikhail <mp39590@gmail.com>
Subject:
Re: J and K keybindings for diff view
To:
Mark Jamsek <mark@jamsek.com>
Cc:
gameoftrees@openbsd.org
Date:
Mon, 18 Jul 2022 23:02:28 +0300

Download raw body.

Thread
On Tue, Jul 19, 2022 at 07:59:30PM +1000, Mark Jamsek wrote:
> On 22-07-19 11:57am, Stefan Sperling wrote:
> > On Tue, Jul 19, 2022 at 07:53:22PM +1000, Mark Jamsek wrote:
> > > On 22-07-17 09:23pm, Mikhail wrote:
> > > > This patch adds J and K bindings for diff view to move to the next and
> > > > previous commits respectively. It mimics keybindings which are found in
> > > > mutt while you're in mail view. I've found it very convenient, because
> > > > you can scroll diff with j/k and when you're done, don't move hands to
> > > > another part of a keyboard to see next/previous commit.
> > > 
> > > I like this. I use it in mutt too and it will be nice to have that
> > > consistency between apps in frequent use.
> > 
> > No objections here. Should these new key bindings be supported
> > in the blame view, too, for consistency?
> 
> Yes, I think that's a good idea.

I can confirm that current patch already does that (input_diff_view
function is used for both cases - log/diff and blame/diff), man page
also correctly describes the behavior.