"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Omar Polo <op@omarpolo.com>
Subject:
Re: reset committer name during rebase and histedit
To:
Stefan Sperling <stsp@stsp.name>
Cc:
gameoftrees@openbsd.org
Date:
Fri, 22 Jul 2022 09:43:04 +0200

Download raw body.

Thread
Stefan Sperling <stsp@stsp.name> wrote:
> This makes the rebase and histedit commands reset committer name in
> newly created commits, based on author info found in the usual way.
> 
> Before this change, the committer field was simply copied from the
> meta-data of each rebased/edited commit. It makes sense to reset this
> field when commits get passed on via someone else (this was suggested
> to me by jrick during r2k22).
> 
> Also, this behaviour change is required to support server-side checks
> which ensure that a committer's name matches authentication credentials
> used to send commits.
> Which is something our own future server should probably do.
> 
> ok?

i missed the case where the committer is someone else and then a commit
gets rebased / histedit'd and we need to override the committer too.

ok op@