On 23-01-07 05:24PM, Stefan Sperling wrote:
> On Sun, Jan 08, 2023 at 03:04:42AM +1100, Mark Jamsek wrote:
> > On 23-01-07 04:48PM, Stefan Sperling wrote:
> > > Both 'got log' and 'tog log' currently display the commit date
> > > between the from: and via: lines. This patch tweaks the display
> > > such that from: and via: appear on consecutive lines. I believe
> > > this looks nicer, especially in case where commits were created
> > > with the -A flag.
> 
> > I'm somewhat ambivalent from an aesthetic perspective: it certainly
> > reads better, but contiguous FROM and VIA lines in the same colour
> > throws me!
> > 
> > I wonder if we need to colour distinguish FROM and VIA now :)
> 
> It looks fine to me the way it is now.
> Of course, this is highly subjective :)

It's definitely growing on me :)

And the improved way it reads outweighs my sensitivity to the
consecutive coloured lines.

> Currently both lines are colored by TOG_COLOR_AUTHOR.
> We could introduce TOG_COLOR_COMMITTER and make it use a separate
> default color if you prefer. I just have a little bit of doubt since
> it would be yet another config knob...

I don't think we need another knob here; like you say it's yet another
decision the user needs to make over something trivial, and it really
does look fine. But thanks for entertaining my thoughts!

-- 
Mark Jamsek <fnc.bsdbox.org>
GPG: F2FF 13DE 6A06 C471 CA80  E6E2 2930 DC66 86EE CF68