"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

Stefan Sperling <stsp@stsp.name>
Re: got histedit tribulations
James Cook <falsifian@falsifian.org>
Ted Bullock <tbullock@comlore.com>, gameoftrees@openbsd.org
Mon, 27 Feb 2023 11:06:54 +0100

Download raw body.

On Mon, Feb 27, 2023 at 09:05:32AM +0000, James Cook wrote:
> > Thanks for pointing this out. I have added hints to the section of
> > the man page which documents the 'edit' command of the histedit script:
> > https://git.gameoftrees.org/gitweb/?p=got.git;a=commitdiff;h=456d8970e
> Thanks, that text confirms what I suspected, and will hopefully be
> useful to others.
> I wonder if it would be good to replace the first sentence with:
> 	Apply the changes from the specified commit, but then interrupt
> 	the histedit operation for amending, without creating a commit.
> My fear is that otherwise a reader might assume at least one commit is
> created by default (though how this would happen is unclear). But I'm
> just speculating.

Thanks, that wording is indeed much clearer. I have applied this change.