"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: fix some fd leaks in error paths and avoid some double close
To:
Christian Weisgerber <naddy@mips.inka.de>
Cc:
gameoftrees@openbsd.org
Date:
Thu, 26 Oct 2023 17:32:42 +0200

Download raw body.

Thread
On Thu, Oct 26, 2023 at 11:23:11AM +0200, Christian Weisgerber wrote:
> Omar Polo:
> 
> > Should we also start to use ibuf_fd_set() instead of
> > reaching into the struct?
> 
> This would mean Got no longer builds on OpenBSD releases before 7.4.
> Is that a concern?

No, that is not an issue.

It's perhaps more of an issue for -portable but I suppose Thomas
can pull in new imsg APIs into compat/imsg.c to avoid breakage.