"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: do not hardcode digest length when parsing packed trees
To:
Omar Polo <op@omarpolo.com>
Cc:
gameoftrees@openbsd.org
Date:
Fri, 12 Jul 2024 15:48:59 +0200

Download raw body.

Thread
On Fri, Jul 12, 2024 at 03:33:56PM +0200, Omar Polo wrote:
> the subject says it all.  there are a few upcoming diff where I'm
> replacing SHA1_DIGEST{,_STRING}_LENGTH with the right length derived
> with got_hash_digest{,_string}_length() but this is a bit more delicate.
> I know that this is a performance-sensitive area and that's why i'm
> passing the idlen instead of having the function computing it.  to be
> fair though i haven't done any benchmark.
> 
> ok?

yes, looks good