"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: Regress failures with git 2.50.0
To:
Christian Weisgerber <naddy@mips.inka.de>
Cc:
gameoftrees@openbsd.org
Date:
Sat, 28 Jun 2025 21:49:36 +0200

Download raw body.

Thread
On Sat, Jun 28, 2025 at 04:46:16PM +0200, Christian Weisgerber wrote:
> Starting with git 2.50.0, git fsck is unhappy about something in
> 
> branch.sh:test_branch_delete_packed()
> 
> git fsck: error: packed-refs.header: badPackedRefHeader: '# pack-refs with:' does not start with '# pack-refs with: '
> fatal: unexpected line in .git/packed-refs: # pack-refs with:
> git fsck failed; leaving test data in /tmp/got-test-branch_delete_packed-mRcjfQ46cy
> 
> and again ref.sh:test_ref_delete()
> 
> git fsck: error: packed-refs.header: badPackedRefHeader: '# pack-refs with:' does not start with '# pack-refs with: '
> fatal: unexpected line in .git/packed-refs: # pack-refs with:
> git fsck failed; leaving test data in /tmp/got-test-ref_delete-T3AMp2Cv3P
> 
> Evidently related to the use of "git -C $testroot/repo pack-refs --all"
> in those tests.  I noticed this when running the tests for 0.115
> on FreeBSD, where the git port has already moved to 2.50.0.

Curious. Does this help?

diff /home/stsp/src/got
path + /home/stsp/src/got
commit - bcd8b7f9afad7734beae751c90cee2ed01466845
blob - b867d92de385084a47936eb776de4a60ca921c58
file + lib/reference.c
--- lib/reference.c
+++ lib/reference.c
@@ -60,7 +60,7 @@
  * so packed-refs files we write contain a minimal header which disables all
  * packed-refs "traits" supported by Git.
  */
-#define GOT_PACKED_REFS_HEADER	"# pack-refs with:"
+#define GOT_PACKED_REFS_HEADER	"# pack-refs with: "
 
 /* A symbolic reference. */
 struct got_symref {