"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
"Omar Polo" <op@omarpolo.com>
Subject:
Re: Regress failures with git 2.50.0
To:
gameoftrees@openbsd.org
Date:
Sun, 29 Jun 2025 11:51:50 +0200

Download raw body.

Thread
Christian Weisgerber <naddy@mips.inka.de> wrote:
> Stefan Sperling:
> 
> > Curious. Does this help?
> 
> > -#define GOT_PACKED_REFS_HEADER	"# pack-refs with:"
> > +#define GOT_PACKED_REFS_HEADER	"# pack-refs with: "
> 
> Yes, indeed, that shuts up git fsck and the regression tests pass again.

Seems git really cares for that trailing whitespace, for e.g.:
https://github.com/git/git/blob/master/refs/packed-backend.c#L727

(grepping for 'pack-refs with:' shows many more instances, not only in
code but also in comments -- with a very quick investigation i failed to
track down when this become a requirement tho)

so, fwiw, ok op@